Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Add Trino HLL Function Compatibility Mapping and last_day_of_month Support(StarRocks#40894) #47529

Merged
merged 2 commits into from
Jun 26, 2024
Merged

[Enhancement] Add Trino HLL Function Compatibility Mapping and last_day_of_month Support(StarRocks#40894) #47529

merged 2 commits into from
Jun 26, 2024

Conversation

happut
Copy link
Contributor

@happut happut commented Jun 26, 2024

Why I'm doing:

In version 3.0 and later, StarRocks supports Trino's SQL_dialect mode; however, ongoing enhancements are necessary to further optimize this functionality, so I added the Trino HLL Function Compatibility Mapping and last_day_of_month Support(#40894)

What I'm doing:

Add Trino HLL Function Compatibility Mapping and last_day_of_month Support(#40894)

Fixes #issue
#40894

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@happut happut requested a review from a team as a code owner June 26, 2024 08:44
@github-actions github-actions bot added the 3.3 label Jun 26, 2024
@mergify mergify bot assigned happut Jun 26, 2024
@happut happut mentioned this pull request Jun 26, 2024
Closed
24 tasks
@happut
Copy link
Contributor Author

happut commented Jun 26, 2024

@Youngwb
Mentor, new pr is here.

@happut happut changed the title [Enhancement] Add Trino HLL Function Compatibility Mapping and last_d… [Enhancement] Add Trino HLL Function Compatibility Mapping and last_day_of_month Support(StarRocks#40894) Jun 26, 2024
Youngwb
Youngwb reviewed Jun 26, 2024
View reviewed changes
...core/src/main/java/com/starrocks/connector/parser/trino/Trino2SRFunctionCallTransformer.java Outdated

private static void registerHLLFunctionTransformer() {
// cardinality -> hll_cardinality
registerFunctionTransformer("cardinality", 1, "hll_cardinality", List.of(Expr.class));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can not just covert cardinality to hll_cardinality, because cardinality can also used for MAP and ARRAY type
https://trino.io/docs/current/functions/array.html#cardinality
https://trino.io/docs/current/functions/map.html#map-functions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can covert cardinality function in another PR

Copy link
Contributor Author

@happut happut Jun 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then I cancel this section first, wait for me to study hll_cardinality in the future, and then submit a new PR with convert of hll_cardinality

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Youngwb
New commit has been pushed.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 26, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 63 / 63 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/parser/trino/Trino2SRFunctionCallTransformer.java 63 63 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@stephen-shelby stephen-shelby merged commit e6c7c3d into StarRocks:main Jun 26, 2024
51 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jun 26, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 26, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 26, 2024
@happut @mergify
[Enhancement] Add Trino HLL Function Compatibility Mapping and last_d…
86d0436 
…ay_of_month Support(#40894) (#47529)

Signed-off-by: happut <[email protected]>
(cherry picked from commit e6c7c3d)
@mergify mergify bot mentioned this pull request Jun 26, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Jun 26, 2024
@mergify @happut
[Enhancement] Add Trino HLL Function Compatibility Mapping and last_d…
66119b5 
…ay_of_month Support(#40894) (backport #47529) (#47538)

Co-authored-by: wangfei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youngwb Youngwb Youngwb approved these changes

@stephen-shelby stephen-shelby stephen-shelby approved these changes

Assignees

@happut happut

Labels
3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@happut @Youngwb @stephen-shelby