Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support trino current_catalog and current_schema function #41319

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

macroguo-ghy
Copy link
Contributor

@macroguo-ghy macroguo-ghy commented Feb 21, 2024

Why I'm doing:

#40894

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@macroguo-ghy
Copy link
Contributor Author

@mergify rebase

Copy link
Contributor

mergify bot commented Feb 21, 2024

rebase

❌ Unable to rebase: user macroguo-ghy is unknown.

Please make sure macroguo-ghy has logged in Mergify dashboard.

@macroguo-ghy
Copy link
Contributor Author

FE UT run timeout, I don't think it is caused by this commit

@stephen-shelby
Copy link
Contributor

FE UT run timeout, I don't think it is caused by this commit

I have rerun it.

@stephen-shelby stephen-shelby enabled auto-merge (squash) February 22, 2024 02:51
auto-merge was automatically disabled February 22, 2024 09:51

Head branch was pushed to by a user without write access

Copy link

sonarcloud bot commented Feb 22, 2024

Copy link

[FE Incremental Coverage Report]

pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/parser/trino/AstBuilder.java 2 2 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@imay imay merged commit 4244719 into StarRocks:main Feb 22, 2024
42 checks passed
@Youngwb
Copy link
Contributor

Youngwb commented Feb 23, 2024

@mergify backport branch-3.2

Copy link
Contributor

mergify bot commented Feb 23, 2024

backport branch-3.2

✅ Backports have been created

@Youngwb
Copy link
Contributor

Youngwb commented Feb 23, 2024

@mergify backport branch-3.1

Copy link
Contributor

mergify bot commented Feb 23, 2024

backport branch-3.1

✅ Backports have been created

@Youngwb
Copy link
Contributor

Youngwb commented Feb 23, 2024

@mergify backport branch-3.0

Copy link
Contributor

mergify bot commented Feb 23, 2024

backport branch-3.0

✅ Backports have been created

wanpengfei-git pushed a commit that referenced this pull request Feb 23, 2024
Youngwb pushed a commit to Youngwb/starrocks that referenced this pull request Feb 23, 2024
Youngwb pushed a commit to Youngwb/starrocks that referenced this pull request Feb 23, 2024
dirtysalt pushed a commit that referenced this pull request Feb 23, 2024
dirtysalt pushed a commit that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants