Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAMEDOTCOM: BUGFIX: TXT records add unneeded quotes #3260

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

tlimoncelli
Copy link
Contributor

@tlimoncelli tlimoncelli commented Dec 17, 2024

Fixes #3259

@tlimoncelli
Copy link
Contributor Author

Gladly!

If you are on a Mac, Linux, or WIndows host, you'll need to install Git and Go. Git has different install instructions for different OSs. Go is on https://go.dev/

cd to somewhere like /tmp or an otherwise unused directory.

git clone https://github.com/StackExchange/dnscontrol.git
cd dnscontrol
git checkout tlim_namedotcom
go install

The last command (go install) will install the dnscontrol binary in your $HOME/bin directory. You should be able to run it by just running "dnscontrol".

Change to the directory with your dnsconfig.js file and run it as normal.

Feel free to ping me with any questions!

@tkurki
Copy link

tkurki commented Dec 18, 2024

Was hoping for a one command docker based build, as I prefer not to taint my host with one time use tools. But thanks, I’ll figure that part out myself if i get around to it.

@tlimoncelli
Copy link
Contributor Author

A docker-based build would be excellent. Sadly, we're not there yet. (CC @cafferata )

@rmc47
Copy link

rmc47 commented Dec 18, 2024

@tkurki while testing #3227, I ran the tests within a Docker container - docker run -it golang grabs the base Go container and pops you into an interactive shell within that environment, then you can run Tom's suggested commands within that.

@tlimoncelli
Copy link
Contributor Author

@rmc47 good idea!

If your dnsconfig.js file is in /THE/PATH you can make that appear in the docker container as /dns:

docker run -it -v /THE/PATH:/dns golang

git clone https://github.com/StackExchange/dnscontrol.git
cd dnscontrol
git checkout tlim_namedotcom
go install

cd /dns
/go/bin/dnscontrol preview

(untested, but it should work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A Name.com TXT entry produces quoted value
4 participants