Open
Conversation
shreyas1599
commented
Jan 22, 2021
- Update an Issue comment
- Labels for issues in a milestone
- Get a single milestone
- Update a milestone
Member
|
@shreyas1599 Thanks for putting up this PR. I'll test it out this week. |
Author
|
@robrbecker thanks. I was looking to fill in the other TODO methods as well but was waiting to see if this gets merged. But now I see in the Discussions tab that you're planning to move to OpenAPI spec so should I not do it? |
Member
|
You can continue with this PR. The open API generator still needs work so
it will be a while before that's ready.
…On Wed, Apr 21, 2021, 12:06 AM Shreyas Thirumalai ***@***.***> wrote:
@robrbecker <https://github.com/robrbecker> thanks. I was looking to fill
in the other TODO methods as well but was waiting to see if this gets
merged. But now I see in the Discussions tab that you're planning to move
to OpenAPI spec so should I not do it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#240 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACM32WX27BDV3C55X6CQSDTJZTQDANCNFSM4WOL5TRA>
.
|
Member
|
@shreyas1599 I'm circling back to this PR. I guess I had never done anything with it since I thought you were going to add more to it. Should we fix this one up and get it merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.