Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve maven build reproducibility #3701

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Janmm14
Copy link
Contributor

@Janmm14 Janmm14 commented Jun 23, 2024

Set versions for common maven plugins in plugin management.

@lax1dude
Copy link
Contributor

lax1dude commented Aug 4, 2024

Even the main Jenkins instance is affected by this, NativeZlibTest only ran testException on the latest build

https://ci.md-5.net/job/BungeeCord/net.md-5$bungeecord-native/1855/testReport/net.md_5.bungee/NativeZlibTest/

@md-5
Copy link
Member

md-5 commented Aug 5, 2024

I'm not really sure this is level of pinning is standard. A better alternative if reproducibility is a concern would be to enforce the Maven version and then specific plugins as needed.

Also you've used a beta /milestone version of the site plugin I think

@Janmm14
Copy link
Contributor Author

Janmm14 commented Aug 5, 2024

@md-5 I am not entirely sure either.

I did use versions listed here: https://maven.apache.org/plugins/ - I think these M versions are safe to use as they are listed there.

Maybe I should change this to "minimum version" as in [1.5,) (see https://maven.apache.org/pom.html#dependency-version-requirement-specification )?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants