Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make protocol limit for plugin messages sent by client configurable #3571

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Outfluencer
Copy link
Collaborator

helps out with #3509

@jewome62
Copy link

@md-5 Do you think it's a possible solution for our problem #3509 ?

@bemoty
Copy link

bemoty commented Jan 19, 2025

Is there something specific this MR is waiting on? It's such a small change, but would be extremely helpful

@Outfluencer
Copy link
Collaborator Author

Is there something specific this MR is waiting on? It's such a small change, but would be extremely helpful

its just waiting for md_5, its a very simple change that was requested by many, i dont know why its not merged yet

@Outfluencer Outfluencer requested a review from md-5 January 20, 2025 07:54
@md-5
Copy link
Member

md-5 commented Jan 20, 2025

Because it's a non-standard option which violates the protocol specification. The whole point of plugin messages (as opposed to custom packets which is what people used to do) is that they can be understood by everyone/everything without requiring special handling. If they require special handling then the whole point is defeated.

@Outfluencer
Copy link
Collaborator Author

Outfluencer commented Jan 20, 2025

Because it's a non-standard option which violates the protocol specification. The whole point of plugin messages (as opposed to custom packets which is what people used to do) is that they can be understood by everyone/everything without requiring special handling. If they require special handling then the whole point is defeated.

I fully agree, but the problem is that the mod devlopers simply don't care what the vanilla limits are, because most servers are using paper or fabric anyways where you can modify the limits.

Also this change does not affect any api and if you not specifically change the value it does not change any of bungeecord behaviour

It would be a favor to all mod users if we just add this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants