Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize docker compose usage & language #4125

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

neolefty
Copy link
Contributor

I think the old versions of docker-compose have percolated out of dev environments by now, since v2 was released in 2020. See https://docs.docker.com/compose/releases/migrate

  • docker-compose –> docker compose
  • docker-compose.yml –> compose.yml
  • Remove deprecated "version" tag from compose.yml (it is causing warnings in the dev env)

@mjy
Copy link
Member

mjy commented Dec 3, 2024

@LocoDelAssembly You mentioned a concern with the change in chat I think?

@LocoDelAssembly
Copy link
Contributor

Missed this one. File rename and removing version seems compatible with the docker version that comes with Ubuntu 22.04 LTS (still supported). However I'd remove the unzip mount point as it is not necessary.

The version number was 2 because I think were using something that was removed in later versions, something related to health checks or detecting when the container is ready, but not currently needed since startup script in app container waits for db to come up before letting TW run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants