add support for specifying container registry

[philip-mannes-cardano]

Please help, we're facing rate throttling by Dockerhub due to this action. Please allow us to specify the registry.

• addresses https://community.sonarsource.com/t/sonarcloud-github-action-registry-hitting-rate-limit/99321/19, please adjust as needed

[marciorgb]

Maybe letting the leading / in the CONTAINER_REGISTRY arg and adding a default value as ""

[philip-mannes-cardano]

Hi @marciorgb, thanks for reaching out. I've been running some tests.. the above won't work.

The problem is that using: docker changes the flow of github actions in a way that images are pulled during the setup step. There's no way to login before the setup step. This will always result in throttling by Dockerhub for users at scale.

The way to address this is by using: composite and by building the container at runtime. Am I missing something? See my update.

[philip-mannes-cardano]

New scans do not pass using this rewrite, the scanned branch is master, though the action is being called from a non-default branch. Please help, Dockerhub throttling caused by this action is blocking all our CICD processes.

[henryju]

Hi,

Thanks for your contribution. We are aware of the rate limit issue and are willing to replace this action with a composite action without relying on Docker.
See for example https://github.com/SonarSource/sonarqube-scan-action/tree/jh/experiment_composite_action

This is likely to come before the end of the year.

[antonioaversa]

Hi @philip-mannes-cardano,
We have just released [email protected]. v4.0.0 removes Docker, moving to a composite action, while v4.1.0 brings several improvements to the action, which is now the single entry-point for SonarQube Server and Cloud (formerly SonarCloud).

You can read about these new releases

• v4.0.0: in our community post or in the GitHub release notes
• v4.1.0: in our community post or in the GitHub release notes

[email protected] should be a drop-in replacement. Please, give it a try and let us know.

[pierre-guillot-gh]

Closing the PR as we won't merge this contribution, as we migrated to composite action. Feel free to continue the conversation here.