SCAN4NET-207 Map sonar.scanner.truststorePath & sonar.scanner.truststorePassword #2307
+143
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
sebastien-marichal
force-pushed
the
sma/props-map
branch
from
ad5be65 to
075a09f
Compare
sebastien-marichal
force-pushed
the
sma/props-map
branch
from
075a09f to
4c3b43f
Compare
martin-strecker-sonarsource
requested changes
Jan 30, 2025
...Scanner.MSBuild.PreProcessor/AnalysisConfigProcessing/Processors/PropertyMappingProcessor.cs
Outdated
Show resolved
Hide resolved
...Scanner.MSBuild.PreProcessor/AnalysisConfigProcessing/Processors/PropertyMappingProcessor.cs
Outdated
Show resolved
Hide resolved
...arScanner.MSBuild.PreProcessor.Test/AnalysisConfigProcessing/AnalysisConfigGeneratorTests.cs
Show resolved
Hide resolved
martin-strecker-sonarsource
approved these changes
Feb 3, 2025
Comment on lines
309
to
310
| bool InvalidPathPredicate(string path) => path.Contains(","); | ||
| } |
There was a problem hiding this comment.
Suggested change
| bool InvalidPathPredicate(string path) => path.Contains(","); | |
| } | |
| } | |
| static bool InvalidPathPredicate(string path) => path.Contains(","); |
There was a problem hiding this comment.
Yes, right, I thought I put it at the end of the method.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCAN4NET-207
First commit is some CaYC
Second commit is the actual change.