Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCAN4NET-160 ComputeProjectBaseDir: Respect SONARQUBE_SCANNER_PARAMS #2263

Merged
merged 3 commits into from
Nov 12, 2024
Merged

SCAN4NET-160 ComputeProjectBaseDir: Respect SONARQUBE_SCANNER_PARAMS #2263

merged 3 commits into from
Nov 12, 2024

Conversation

gregory-paidis-sonarsource
Copy link
Contributor

@gregory-paidis-sonarsource gregory-paidis-sonarsource commented Nov 8, 2024 •
edited by jira bot
Loading

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title ComputeProjectBaseDir: Respect SONARQUBE_SCANNER_PARAMS SCAN4NET-160 ComputeProjectBaseDir: Respect SONARQUBE_SCANNER_PARAMS Nov 8, 2024
costin-zaharia-sonarsource
costin-zaharia-sonarsource requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add an integration test with SONARQUBE_SCANNER_PARAMS?

src/SonarScanner.MSBuild.Shim/PropertiesFileGenerator.cs Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

costin-zaharia-sonarsource
costin-zaharia-sonarsource approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@costin-zaharia-sonarsource costin-zaharia-sonarsource merged commit 5d4c523 into master Nov 12, 2024
15 checks passed
@costin-zaharia-sonarsource costin-zaharia-sonarsource deleted the greg/refactor-projectBaseDir-calculation branch November 12, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costin-zaharia-sonarsource costin-zaharia-sonarsource costin-zaharia-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregory-paidis-sonarsource @costin-zaharia-sonarsource