Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCAN4NET-152 Add ScannerEnvProperties to SettingsFile #2260

Closed
wants to merge 8 commits into from

Conversation

martin-strecker-sonarsource
Copy link
Contributor

@martin-strecker-sonarsource martin-strecker-sonarsource commented Nov 5, 2024

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Add ScannerEnvProperties to SettingsFile SCAN4NET-156 Add ScannerEnvProperties to SettingsFile Nov 5, 2024
@martin-strecker-sonarsource martin-strecker-sonarsource changed the title SCAN4NET-156 Add ScannerEnvProperties to SettingsFile SCAN4NET-152 Add ScannerEnvProperties to SettingsFile Nov 5, 2024
@martin-strecker-sonarsource
Copy link
Contributor Author

martin-strecker-sonarsource commented Nov 6, 2024

It is unclear what is actually wrong. Given the IT I added, the behavior is a bit odd, but as expected: All env variable settings are propagated to the scanner-cli.jar. The oddity is that the sonar.projectBaseDir setting from the env variable is behaving like so:

Let's assume this situation

  • defaultValue calculated: sonar.projectBaseDir=default
  • set via env: sonar.projectBaseDir=dirEnv

sonar-cli.jar properties file

sonar.projectBaseDir appears twice but only with the default

  • sonar.projectBaseDir=default
  • sonar.projectBaseDir=default

sonar-cli.jar log output

  • INFO: Base dir: dirEnv

I don't know if there is anything we need to fix here.

Copy link

sonarqubecloud bot commented Nov 7, 2024

@gregory-paidis-sonarsource
Copy link
Contributor

Duplicate of this PR.

@gregory-paidis-sonarsource gregory-paidis-sonarsource deleted the Martin/ScannerEnvSupport branch November 14, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants