Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCAN4NET-119 Remove deprecated dotnet versions and add the new ones #2230

Merged
merged 1 commit into from
Oct 21, 2024
Merged

SCAN4NET-119 Remove deprecated dotnet versions and add the new ones #2230

merged 1 commit into from
Oct 21, 2024
+50 −819

Conversation

costin-zaharia-sonarsource
Copy link
Member

@costin-zaharia-sonarsource costin-zaharia-sonarsource commented Oct 14, 2024 •
edited by jira bot
Loading

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Remove deprecated dotnet versions and add the new ones SCAN4NET-119 Remove deprecated dotnet versions and add the new ones Oct 14, 2024
@costin-zaharia-sonarsource costin-zaharia-sonarsource force-pushed the costin/its-dotnet-cleanup branch 10 times, most recently from 06d0cd7 to 20afcb9 Compare October 16, 2024 11:42
martin-strecker-sonarsource
martin-strecker-sonarsource requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions to make sure we do not lose too much coverage.

@costin-zaharia-sonarsource costin-zaharia-sonarsource force-pushed the costin/its-dotnet-cleanup branch 2 times, most recently from 344c4c2 to cf049f5 Compare October 18, 2024 12:09
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

martin-strecker-sonarsource
martin-strecker-sonarsource approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin-zaharia-sonarsource costin-zaharia-sonarsource merged commit 588f38f into master Oct 21, 2024
16 checks passed
@costin-zaharia-sonarsource costin-zaharia-sonarsource deleted the costin/its-dotnet-cleanup branch October 21, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-strecker-sonarsource martin-strecker-sonarsource martin-strecker-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@costin-zaharia-sonarsource @martin-strecker-sonarsource