Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCAN4NET-99 Bump dependencies on Angular and React ClientApp #2213

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

CristianAmbrosini
Copy link
Contributor

@CristianAmbrosini CristianAmbrosini commented Sep 25, 2024

I used npm audit fix—-force to update the dependencies of MultiLanguageSupportReact and MultiLanguageSupportAngular projects to the latest versions and resolve vulnerabilities.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Bump dependencies on Angular and React ClientApp SCAN4NET-99 Bump dependencies on Angular and React ClientApp Sep 25, 2024
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the report, these packages should be updated:

  • postcss
  • webpack-dev-middleware
  • webpack
  • send

Only the send package seems to be updated to expected version. I don't see the others in this PR.

@CristianAmbrosini
Copy link
Contributor Author

CristianAmbrosini commented Sep 27, 2024

@pavel-mikula-sonarsource, good catch, npm audit fix was detecting those vulnerabilities but was not bumping them for some reason (package-lock was probably messed up).

For future reference, I had to:

  • delete package-lock.json
  • delete node_modules folder
  • run npm install again

This appears to have resolved the issue.

@CristianAmbrosini
Copy link
Contributor Author

I have the feeling that certain high-severity vulnerabilities may frequently appear in some of these package versions, whether they are direct dependencies or transitive ones. We should find a more clever solution, I was not able to find if it's possible to exclude some folders from the scan. What about just ignoring those emails if the target is MultiLanguageSupportAngular or MultiLanguageSupportReact project? I would also extend it to the whole its folder, I don't think we care too much if there are vulnerabilities over there, correct me if I'm wrong. WDYT?

Copy link

Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 5ff8f6d into master Oct 28, 2024
15 checks passed
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the cristian/bump-npm-dep2 branch October 28, 2024 09:30
@pavel-mikula-sonarsource
Copy link
Contributor

The idea is to try to bump it once and see how often it will re-appear. If it comes again more than once a year, we'll just accept the report as won't fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants