-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCAN4NET-99 Bump dependencies on Angular and React ClientApp #2213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the report, these packages should be updated:
- postcss
- webpack-dev-middleware
- webpack
- send
Only the send
package seems to be updated to expected version. I don't see the others in this PR.
@pavel-mikula-sonarsource, good catch, For future reference, I had to:
This appears to have resolved the issue. |
I have the feeling that certain high-severity vulnerabilities may frequently appear in some of these package versions, whether they are direct dependencies or transitive ones. We should find a more clever solution, I was not able to find if it's possible to exclude some folders from the scan. What about just ignoring those emails if the target is |
74f4b36
to
9210852
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The idea is to try to bump it once and see how often it will re-appear. If it comes again more than once a year, we'll just accept the report as won't fix |
I used
npm audit fix—-force
to update the dependencies of MultiLanguageSupportReact and MultiLanguageSupportAngular projects to the latest versions and resolve vulnerabilities.