SCAN4NET-88 INFO level for invalid project GUIDs messages #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
costin-zaharia-sonarsource
force-pushed
the
costin/invalid-guid-message
branch
from
e18aff1 to
a060a22
Compare
costin-zaharia-sonarsource
force-pushed
the
costin/invalid-guid-message
branch
from
a060a22 to
f89f860
Compare
| @@ -145,7 +145,7 @@ Error: {1}</value> | |||
| <value>Failed to resolve path relative to project file. Path: {0}</value> | |||
| </data> | |||
| <data name="WPIF_MissingOrInvalidProjectGuid" xml:space="preserve"> | |||
| <value>The project does not have a valid ProjectGuid. Analysis results for this project will not be uploaded. Project file: {0}</value> | |||
| <value>Sonar: The project does not have a valid ProjectGuid. Analysis results for this project will not be uploaded. Project file: {0}</value> | |||
There was a problem hiding this comment.
When we log messages during project build, we prefix them with "Sonar:". The message will appear in the following form:
SonarWriteProjectData:
Sonar: The project does not have a valid ProjectGuid. Analysis results for this project will not be uploaded. Project file: D:\src\playgroud\AzureFunctions\AzureFunctions\obj\Debug\net8.0\WorkerExtensions\WorkerExtensions.csproj
Sonar: (WorkerExtensions.csproj) Project processed successfully
| @@ -106,7 +106,7 @@ public override bool Execute() | |||
| } | |||
| else | |||
| { | |||
| Log.LogWarning(Resources.WPIF_MissingOrInvalidProjectGuid, FullProjectPath); | |||
| Log.LogMessage(MessageImportance.High, Resources.WPIF_MissingOrInvalidProjectGuid, FullProjectPath); | |||
There was a problem hiding this comment.
We want to set high importance so the message will be displayed even when dotnet build is called without a verbosity parameter.
The logs will look like this:
Determining projects to restore...
All projects are up-to-date for restore.
WorkerExtensions -> D:\src\playgroud\AzureFunctions\AzureFunctions\obj\Debug\net8.0\WorkerExtensions\buildout\Microsoft.Azure.Functions.Worker.Extensions.dll
Sonar: The project does not have a valid ProjectGuid. Analysis results for this project will not be uploaded. Project file: D:\src\playgroud\AzureFunctions\AzureFunctions\obj\Debug\net8.0\WorkerExtensions\WorkerExtensions.csproj
Sonar: (WorkerExtensions.csproj) Project processed successfully
AzureFunctions -> D:\src\playgroud\AzureFunctions\AzureFunctions\bin\Debug\net8.0\AzureFunctions.dll
Sonar: (AzureFunctions.csproj) Project processed successfully
|
costin-zaharia-sonarsource
requested review from
gregory-paidis-sonarsource
and removed request for
CristianAmbrosini
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCAN4NET-88
Part of https://sonarsource.atlassian.net/browse/SCAN4NET-59