SCAN4NET-87 Cleanup E2EAnalysisTests #2204
Conversation
hashicorp-vault-sonar-prod
bot
changed the title
| @@ -268,7 +263,7 @@ public void E2E_HasManagedAndContentFiles_VB() | |||
| actualStructure.AssertExpectedFileList("\\none1.txt", "\\code1.vb", "\\code2.vb"); | |||
| } | |||
|
|
|||
| [TestMethod] // SONARMSBRU-104: files under the obj folder should be excluded from analysis | |||
There was a problem hiding this comment.
Is this ticket not relevant anymore?
There was a problem hiding this comment.
The project no longer exists on Jira. I'm not sure what's the history of this.
There was a problem hiding this comment.
There are a few more comments like these but those seem to have a more useful message. Maybe I should remove the issue id from all of them and just keep the text.
There was a problem hiding this comment.
I'm wondering if the message is explaining what is still to be implemented (Jira ticket still todo) or it's explaining the implementation (referencing the closed ticket in Jira). If it's the first, than I'm afraid that leaving the message might be confusing
There was a problem hiding this comment.
The test already checks that the files from the obj folder are excluded (see also the test name). My understanding is that the issue was fixed, and a link was added to the issue for history purposes.
There was a problem hiding this comment.
Then it's fine for me to remove all the Jira identifiers and leave the comment 👍
| </Target> | ||
|
|
||
| </Project> | ||
|
|
There was a problem hiding this comment.
I think you can remove a few more empty lines
| <Import Project='$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), SonarQube.Integration.targets))SonarQube.Integration.targets' /> | ||
| <Import Project='$(MSBuildToolsPath)\Microsoft.CSharp.targets' /> | ||
| </Project> | ||
|
|
costin-zaharia-sonarsource
force-pushed
the
costin/cleanup-E2EAnalysisTests
branch
from
7ef0639 to
77da7cd
Compare
|
costin-zaharia-sonarsource
deleted the
costin/cleanup-E2EAnalysisTests
branch
SCAN4NET-87
Part of https://sonarsource.atlassian.net/browse/SCAN4NET-59