Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCAN4NET-81] Display an info message in the logs about projectBaseDir change #2201

Merged
merged 7 commits into from
Sep 19, 2024
Merged

[SCAN4NET-81] Display an info message in the logs about projectBaseDir change #2201

merged 7 commits into from
Sep 19, 2024

Conversation

CristianAmbrosini
Copy link
Contributor

@CristianAmbrosini CristianAmbrosini commented Sep 18, 2024 •
edited by jira bot
Loading

@CristianAmbrosini CristianAmbrosini marked this pull request as draft September 18, 2024 14:41
@CristianAmbrosini CristianAmbrosini force-pushed the cristian/log-info-projectBaseDir branch from c7cbf3c to be0a2e9 Compare September 18, 2024 15:20
@CristianAmbrosini CristianAmbrosini marked this pull request as ready for review September 19, 2024 09:14
costin-zaharia-sonarsource
costin-zaharia-sonarsource approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only two small comments.

@CristianAmbrosini CristianAmbrosini enabled auto-merge (squash) September 19, 2024 11:51
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@CristianAmbrosini CristianAmbrosini merged commit a6d2cc2 into master Sep 19, 2024
14 checks passed
@CristianAmbrosini CristianAmbrosini deleted the cristian/log-info-projectBaseDir branch September 19, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregory-paidis-sonarsource gregory-paidis-sonarsource gregory-paidis-sonarsource left review comments

@costin-zaharia-sonarsource costin-zaharia-sonarsource costin-zaharia-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CristianAmbrosini @costin-zaharia-sonarsource @gregory-paidis-sonarsource