Infra: Update the UTs and ITs to be able to run on .NET 9 preview #2166
Conversation
terraform-techuser
changed the title
costin-zaharia-sonarsource
force-pushed
the
costin/test-ami
branch
4 times, most recently
from
18efca3
to
08d6bcb
Compare
| @@ -826,7 +826,7 @@ public void E2E_TestProjects_ProtobufsUpdated() | |||
| // Assert | |||
| result.AssertTargetExecuted("FixUpTestProjectOutputs"); | |||
|
|
|||
| var protobufDir = Path.Combine(result.GetPropertyValue("ProjectSpecificOutDir"), "subdir1"); | |||
There was a problem hiding this comment.
MsBuild structured logger has an issue when reading the bin files generated by .NET 9 and the property names got changed. I extracted it to a variable to ease the update when the problem will be addressed.
| @@ -17,7 +17,7 @@ | |||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | |||
| </PackageReference> | |||
| <PackageReference Include="Microsoft.Build.Framework" Version="17.8.3" /> | |||
| <PackageReference Include="MSBuild.StructuredLogger" Version="2.2.243" /> | |||
| <PackageReference Include="MSBuild.StructuredLogger" Version="2.2.291" /> | |||
There was a problem hiding this comment.
I've tried to update to the latest version but the issue is still present.
azure-pipelines.yml
Outdated
| pool: | ||
| name: .net-bubble-aws-re-team-dev | ||
| demands: EnvName -equals pr-133 |
There was a problem hiding this comment.
This will be removed before the merge to master.
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netcoreapp2.1</TargetFramework> | |||
| <TargetFramework>net48</TargetFramework> | |||
There was a problem hiding this comment.
MsBuild 15, after .NET 9 update, fails to build the projects if they are targeting .NET Standard 2.0 or 2.1 so I've changed the target versions to either net48 if they can target a runtime or netstandard1.6 for Xamarin.
The current .NET SDK does not support targeting .NET Standard 2.0.
costin-zaharia-sonarsource
changed the title
Tests/SonarScanner.MSBuild.Tasks.IntegrationTest/Infrastructure/TargetConstants.cs
Show resolved
Hide resolved
costin-zaharia-sonarsource
force-pushed
the
costin/test-ami
branch
from
08d6bcb
to
7da27b8
Compare
|
SCAN4NET-30