Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCAN4NET-23: Exclude coverage files manually #2161

Merged
merged 2 commits into from
Aug 23, 2024
Merged

SCAN4NET-23: Exclude coverage files manually #2161

merged 2 commits into from
Aug 23, 2024

Conversation

gregory-paidis-sonarsource
Copy link
Contributor

@gregory-paidis-sonarsource gregory-paidis-sonarsource commented Aug 22, 2024 •
edited by jira bot
Loading

Base automatically changed from greg/enable-exclusions-multi-file to master August 22, 2024 15:37
@gregory-paidis-sonarsource gregory-paidis-sonarsource force-pushed the greg/exclude-coverage-paths-hack branch 3 times, most recently from 4267d85 to dbf6312 Compare August 22, 2024 15:49
costin-zaharia-sonarsource
costin-zaharia-sonarsource approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Just two small improvements that can be done.

src/SonarScanner.MSBuild.PreProcessor/AnalysisConfigGenerator.cs Outdated Show resolved Hide resolved
src/SonarScanner.MSBuild.PreProcessor/AnalysisConfigGenerator.cs Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gregory-paidis-sonarsource gregory-paidis-sonarsource merged commit 3604f80 into master Aug 23, 2024
15 checks passed
@gregory-paidis-sonarsource gregory-paidis-sonarsource deleted the greg/exclude-coverage-paths-hack branch August 23, 2024 15:37
gregory-paidis-sonarsource added a commit that referenced this pull request Aug 30, 2024
@gregory-paidis-sonarsource
SCAN4NET-23: Exclude coverage files manually (#2161)
d6a9a59
costin-zaharia-sonarsource pushed a commit that referenced this pull request Aug 30, 2024
@gregory-paidis-sonarsource @costin-zaharia-sonarsource
SCAN4NET-23: Exclude coverage files manually (#2161)
4897c9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costin-zaharia-sonarsource costin-zaharia-sonarsource costin-zaharia-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregory-paidis-sonarsource @costin-zaharia-sonarsource