Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JRE cache: NRE on failed download response #2062

Merged
merged 1 commit into from
Jul 17, 2024
Merged

JRE cache: NRE on failed download response #2062

merged 1 commit into from
Jul 17, 2024

Conversation

martin-strecker-sonarsource
Copy link
Contributor

@martin-strecker-sonarsource martin-strecker-sonarsource commented Jul 16, 2024 •
edited
Loading

Fixes #2060

The new real-world log output looks like so:

20:14:14.907  JreResolver: Resolving JRE path. Retrying...
20:14:14.907  Downloading from http://localhost:5080/analysis/jres?os=windows&arch=x64...
20:14:15.922  Response received from http://localhost:5080/analysis/jres?os=windows&arch=x64...
20:14:15.922  JreResolver: Cache miss. Attempting to download JRE.
20:14:15.923  Starting the Java Runtime Environment download.
20:14:15.923  Downloading Java JRE from analysis/jres/29a1a704-026c-4c58-9b81-ae9bc0ab2961.
20:14:15.924  Downloading from http://localhost:5080/analysis/jres/29a1a704-026c-4c58-9b81-ae9bc0ab2961...
20:14:15.928  Response received from http://localhost:5080/analysis/jres/29a1a704-026c-4c58-9b81-ae9bc0ab2961...
20:14:15.928  Downloading from http://localhost:5080/analysis/jres/29a1a704-026c-4c58-9b81-ae9bc0ab2961 failed. Http status code is NotFound.
20:14:15.929  Deleting file 'E:\UserHome\cache\d3bee954a2eabbe9ad76cdc22a1cfefb5236e7fe875bd0336320de49472ddc6f\wjzdwg3e.ldq'.
20:14:15.929  The download of the Java runtime environment from the server failed with the exception 'The download stream is null. The server likely returned an error status code.'.
20:14:15.929  JreResolver: Download failure. The download of the Java runtime environment from the server failed with the exception 'The download stream is null. The server likely returned an error status code.'.
20:14:15.931  Fetching analysis configuration settings...

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@martin-strecker-sonarsource martin-strecker-sonarsource marked this pull request as ready for review July 17, 2024 14:51
gregory-paidis-sonarsource
gregory-paidis-sonarsource approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregory-paidis-sonarsource gregory-paidis-sonarsource merged commit 987bdec into master Jul 17, 2024
17 checks passed
@gregory-paidis-sonarsource gregory-paidis-sonarsource deleted the Martin/JRE_Cache_DownloadFail branch July 17, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregory-paidis-sonarsource gregory-paidis-sonarsource gregory-paidis-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JRE cache: NRE on failed download response
2 participants
@martin-strecker-sonarsource @gregory-paidis-sonarsource