-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JRE Provisioning: Rework file permissions on linux #2058
JRE Provisioning: Rework file permissions on linux #2058
Conversation
bc4edbd
to
191e615
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some cleanup is needed in the FilePermissionsWrapper class.
src/SonarScanner.MSBuild.PreProcessor/FilePermissionsWrapper.cs
Outdated
Show resolved
Hide resolved
src/SonarScanner.MSBuild.PreProcessor/FilePermissionsWrapper.cs
Outdated
Show resolved
Hide resolved
src/SonarScanner.MSBuild.PreProcessor/FilePermissionsWrapper.cs
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Mono.Posix did not work on Alpine already, and the way it is build would mess with our release (it requires a multi-platform SO dependency).
We will keep it simple and use
chmod
everywhere.