Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRE Provisioning: Rework file permissions on linux #2058

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

gregory-paidis-sonarsource
Copy link
Contributor

@gregory-paidis-sonarsource gregory-paidis-sonarsource commented Jul 15, 2024

Mono.Posix did not work on Alpine already, and the way it is build would mess with our release (it requires a multi-platform SO dependency).

We will keep it simple and use chmod everywhere.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanup is needed in the FilePermissionsWrapper class.

Copy link

sonarcloud bot commented Jul 16, 2024

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martin-strecker-sonarsource martin-strecker-sonarsource merged commit 6abc171 into master Jul 16, 2024
17 checks passed
@martin-strecker-sonarsource martin-strecker-sonarsource deleted the greg/fix-file-permissions branch July 16, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants