JRE Provisioning: Add ITs for SonarQube #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregory-paidis-sonarsource
force-pushed
the
greg/sq-its
branch
4 times, most recently
from
8f21b95
to
4879fde
Compare
| // provisioning does not exist before 10.6 | ||
| if (!ORCHESTRATOR.getServer().version().isGreaterThanOrEquals(10, 6)) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
The SQ tests run for a lot of versions, going back until 8.9.
I prefer to do this cheap check here, instead of messing with the regex of azure pipelines yml.
If you have any other ideas, let me know.
There was a problem hiding this comment.
This is okay in principal and was done before. The correct way to do it is using assumeTrue, though:
gregory-paidis-sonarsource
force-pushed
the
greg/sq-its
branch
2 times, most recently
from
b814bc2
to
4b5645c
Compare
gregory-paidis-sonarsource
force-pushed
the
greg/sq-its
branch
from
4b5645c
to
6930b58
Compare
gregory-paidis-sonarsource
assigned martin-strecker-sonarsource and unassigned gregory-paidis-sonarsource
gregory-paidis-sonarsource
force-pushed
the
greg/sq-its
branch
2 times, most recently
from
1f234f3
to
c245951
Compare
martin-strecker-sonarsource
requested changes
Jul 16, 2024
| // provisioning does not exist before 10.6 | ||
| if (!ORCHESTRATOR.getServer().version().isGreaterThanOrEquals(10, 6)) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
This is okay in principal and was done before. The correct way to do it is using assumeTrue, though:
martin-strecker-sonarsource
assigned gregory-paidis-sonarsource and unassigned martin-strecker-sonarsource
github-actions
bot
assigned gregory-paidis-sonarsource and unassigned gregory-paidis-sonarsource
gregory-paidis-sonarsource
force-pushed
the
greg/sq-its
branch
from
c245951
to
89447f4
Compare
|
martin-strecker-sonarsource
approved these changes
Jul 17, 2024
github-actions
bot
assigned gregory-paidis-sonarsource and unassigned martin-strecker-sonarsource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.