Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITs: Update package in ReproAzureFunctions project to not raise alerts on Mend #2047

Merged
merged 9 commits into from
Jul 16, 2024

Conversation

Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions about the change in the IT test implementation

Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
One small change to do before merging.

@@ -909,13 +909,8 @@ void testAzureFunctions_WithWrongBaseDirectory_AnalysisSucceeds() throws IOExcep
assertThat(buildResult.isSuccess()).isTrue();
// ToDo this will be fixed by https://github.com/SonarSource/sonar-scanner-msbuild/issues/1309
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line as the issue is closed

Copy link

sonarcloud bot commented Jul 16, 2024

@mary-georgiou-sonarsource mary-georgiou-sonarsource merged commit 8553b2a into master Jul 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants