Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub workflow: Add slack to ToggleLockBranch #1657

Merged
merged 3 commits into from
Aug 21, 2023
Merged

GitHub workflow: Add slack to ToggleLockBranch #1657

merged 3 commits into from
Aug 21, 2023

Conversation

andrei-epure-sonarsource
Copy link
Contributor

@andrei-epure-sonarsource andrei-epure-sonarsource commented Aug 14, 2023 •
edited
Loading

pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noise reduction.

Let's use this branch to unlock the master for version bump to test it. Just in case something is wrong with vault.

.github/workflows/ToggleLockBranch.yml Outdated Show resolved Hide resolved
@pavel-mikula-sonarsource
Copy link
Contributor

I've merged my suggestion from GitHub UI

@pavel-mikula-sonarsource pavel-mikula-sonarsource changed the title Update ToggleBranch w/ slack GitHub workflow: Add slack to ToggleLockBranch Aug 15, 2023
@pavel-mikula-sonarsource
Copy link
Contributor

It doesn't work. There's something wrong with Vault config. I'll contact REs.

Please use the master version of the action to unblock the version bump.

@pavel-mikula-sonarsource
Copy link
Contributor

https://sonarsource.atlassian.net/browse/BUILD-3608

@matemoln
Copy link
Contributor

https://sonarsource.atlassian.net/browse/BUILD-3608

The change is deployed and the slack token is available for the repository.

pavel-mikula-sonarsource
pavel-mikula-sonarsource approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@andrei-epure-sonarsource andrei-epure-sonarsource merged commit 6bd037f into master Aug 21, 2023
21 checks passed
@andrei-epure-sonarsource andrei-epure-sonarsource deleted the andrei/update-gh-action branch August 21, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-mikula-sonarsource pavel-mikula-sonarsource pavel-mikula-sonarsource approved these changes

Assignees

@andrei-epure-sonarsource andrei-epure-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrei-epure-sonarsource @pavel-mikula-sonarsource @matemoln