Skip to content

Conversation

@simon-the-shark
Copy link
Member

@simon-the-shark simon-the-shark commented Feb 1, 2026

Important

Refactor HTTP request handling in cache.dart and translate.dart to use Dio extensions for improved clarity and efficiency.

  • Behavior:
    • Refactor getAndCacheData in cache.dart to use dio.safeGet instead of safeGetWatch.
    • Refactor getAndCacheDataWithTranslation in translate.dart to pre-watch localeFuture.
  • Functions:
    • Move safeRequest to top-level function in offline_error.dart.
    • Add safeGet extension on Dio in offline_error.dart.
  • Misc:
    • Remove unused imports in offline_error.dart.

This description was created by Ellipsis for d00314e. You can customize this summary. It will automatically update as commits are pushed.

@simon-the-shark simon-the-shark self-assigned this Feb 1, 2026
@simon-the-shark simon-the-shark added the bug Something isn't working label Feb 1, 2026
@github-project-automation github-project-automation bot moved this to Todo in ToPWR Feb 1, 2026
@simon-the-shark simon-the-shark moved this from Todo to In review in ToPWR Feb 1, 2026
@simon-the-shark simon-the-shark merged commit c35b3e6 into main Feb 1, 2026
6 checks passed
@simon-the-shark simon-the-shark deleted the fix-chengelog-init branch February 1, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size/M

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

2 participants