improve imprecise constant for hexagon shape #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.75 is a very bad aproximation for 1.732050807568877 = cos(30) * 2. I don't think we need to optimize here and hardcode the constant - better use a readable calculation.
|
Oh sorry, I think that should go upstream to elmom/MCAD, not here. |
diara628
added a commit
that referenced
this pull request
Apr 13, 2020
linear bearing model and a minor fix of stepper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.75 is a very bad aproximation for 1.732050807568877 = cos(30) * 2. I don't think we need to optimize here and hardcode the constant - better use a readable calculation.