Adds Aave token metadata to mainnet environment #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgeddes
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Looks good.
Though we need to move away from a having the UI depend on a hardcoded list of tokens. Otherwise we will repeat this work every few weeks.
Surely we can update the UI to query the the token metadata on demand for unknown tokens?
@yrong do think we can populate the indexer database with token metadata?
Either way @claravanstaden can add you a ticket to track this work?
alistair-singh
approved these changes
Jan 16, 2025
Yeah, we can index the tokens registered through our bridge. |
# Conflicts: # web/packages/api/package.json # web/packages/contract-types/package.json # web/packages/test/package.json # web/pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.