Skip to content

Primary render fallback#1680

Merged
cmeissl merged 6 commits intomasterfrom
feature/primary_render_fallback
Apr 16, 2025
Merged

Primary render fallback#1680
cmeissl merged 6 commits intomasterfrom
feature/primary_render_fallback

Conversation

@cmeissl
Copy link
Collaborator

@cmeissl cmeissl commented Mar 16, 2025

This adds support for display only nodes by falling back to the primary gpu for rendering.
In addition to the render fallback it also tries to import foreign gbm buffers through dmabuf export/import.

Unfortunately it seems the DisplayLink driver has some issues regarding vsync and will issue a vblank right after
scheduling a page flip. This leads to visual tearing, probably caused by the user-space driver part. As a mitigation this PR also adds a way to throttle vblanks.

@cmeissl cmeissl force-pushed the feature/primary_render_fallback branch from d2f7e1f to 4b808ab Compare March 16, 2025 12:55
@cmeissl cmeissl force-pushed the feature/primary_render_fallback branch 4 times, most recently from 57aacfc to 16c1a0e Compare March 22, 2025 11:59
@cmeissl cmeissl marked this pull request as ready for review March 22, 2025 12:05
@cmeissl cmeissl requested review from Drakulix and ids1024 March 22, 2025 12:05
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.83%. Comparing base (2cf66ca) to head (e7bf5dc).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (2cf66ca) and HEAD (e7bf5dc). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (2cf66ca) HEAD (e7bf5dc)
wlcs-buffer 1 0
wlcs-core 1 0
wlcs-pointer-input 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #1680       +/-   ##
==========================================
- Coverage   19.17%   6.83%   -12.35%     
==========================================
  Files         175     175               
  Lines       28562   28569        +7     
==========================================
- Hits         5478    1953     -3525     
- Misses      23084   26616     +3532     
Flag Coverage Δ
wlcs-buffer ?
wlcs-core ?
wlcs-output 6.83% <ø> (-0.01%) ⬇️
wlcs-pointer-input ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmeissl cmeissl force-pushed the feature/primary_render_fallback branch from 16c1a0e to 2148ea6 Compare March 29, 2025 16:41
@cmeissl cmeissl requested a review from Drakulix March 29, 2025 16:47
@cmeissl cmeissl force-pushed the feature/primary_render_fallback branch from 2148ea6 to e7bf5dc Compare April 14, 2025 14:19
@cmeissl cmeissl force-pushed the feature/primary_render_fallback branch from e7bf5dc to 800eb1a Compare April 16, 2025 16:38
@cmeissl cmeissl force-pushed the feature/primary_render_fallback branch from 800eb1a to 119b373 Compare April 16, 2025 16:39
@cmeissl cmeissl requested a review from Drakulix April 16, 2025 16:41
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@cmeissl cmeissl merged commit 16b0416 into master Apr 16, 2025
13 checks passed
@cmeissl cmeissl deleted the feature/primary_render_fallback branch April 16, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants