Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shm: Use OnceLock instead of static mut #1548

Merged
merged 1 commit into from
Sep 25, 2024
Merged

shm: Use OnceLock instead of static mut #1548

merged 1 commit into from
Sep 25, 2024

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Sep 25, 2024

Fixes warning on nightly Rust.

@ids1024
shm: Use OnceLock instead of static mut
468c639 
Fixes warning on nightly Rust.
@ids1024
Copy link
Member Author

ids1024 commented Sep 25, 2024

I see #1546 also has a fix for this.

But using OnceLock to avoid a static mut entirely is probably the cleaner solution, unless anyone sees a problem with this.

cmeissl
cmeissl approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@cmeissl cmeissl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is a cleaner solution

@cmeissl cmeissl merged commit 950458c into Smithay:master Sep 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmeissl cmeissl cmeissl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ids1024 @cmeissl