-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC Begone delegate macros #1327
base: master
Are you sure you want to change the base?
Conversation
This should genuinely make adding a simple protocol to Smithay take about half as much effort as it currently does. (The less annoying half.) It's great to see we can do this without radically changing the API! |
b27cb8e
to
e58193b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1327 +/- ##
==========================================
- Coverage 20.55% 20.52% -0.04%
==========================================
Files 158 159 +1
Lines 25868 25873 +5
==========================================
- Hits 5317 5310 -7
- Misses 20551 20563 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…o braking after drop of macros)
e58193b
to
8193f8d
Compare
Based on Smithay/wayland-rs#699
Removes all delegate macros, as well as redundant type constraints on
D
Both this PR as well as wayland-rs part attempt to be non-braking changes, the transition should be smooth 🤞