Implement Clone and Default for WeakLoopHandle manually
#219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #219 +/- ##
==========================================
+ Coverage 85.54% 86.28% +0.74%
==========================================
Files 13 15 +2
Lines 1888 2078 +190
==========================================
+ Hits 1615 1793 +178
- Misses 273 285 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ids1024
reviewed
Jan 12, 2025
| @@ -332,6 +332,15 @@ impl<Data> Debug for WeakLoopHandle<'_, Data> { | |||
| } | |||
| } | |||
|
|
|||
| impl<Data> Clone for WeakLoopHandle<'_, Data> { | |||
There was a problem hiding this comment.
Might be good to add a comment mentioning why it isn't just derived.
There was a problem hiding this comment.
Comments added, also changed Default to manual.
The derived `Clone`/`Default` implementation adds `Clone`/`Default` bound on the generic parameter `Data`.
Paraworker
force-pushed
the
manual-debug-impl
branch
from
3408b55 to
1bab16d
Compare
Paraworker
changed the title
Clone for WeakLoopHandle manuallyClone and Default for WeakLoopHandle manually
notgull
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suddenly realized this...
The derived
Clone/Defaultimplementation addsClone/Defaultbound on the generic parameterData.