feat(webhooks): only find executable webhooks (discordjs#900)

Smarttiger2338 · Dec 14, 2021 · 8ca8c74 · 8ca8c74
1 parent ecd614f
commit 8ca8c74
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/code-samples/popular-topics/webhooks/13/using-Webhook.js b/code-samples/popular-topics/webhooks/13/using-Webhook.js
@@ -11,7 +11,11 @@ client.once('ready', async () => {
 	const channel = client.channels.get('222197033908436994');
 	try {
 		const webhooks = await channel.fetchWebhooks();
-		const webhook = webhooks.first();
+		const webhook = webhooks.find(wh => wh.token);
+
+		if (!webhook) {
+			return console.log('No webhook was found that I can use!');
+		}
 
 		await webhook.send({
 			content: 'Webhook test',

diff --git a/guide/popular-topics/webhooks.md b/guide/popular-topics/webhooks.md
@@ -125,7 +125,7 @@ webhookClient.send({
 });
 ```
 
-Example using a Webhook:
+Try to find a webhook your bot knows the token for. This makes sure your bot can execute the webhook later on.
 
 ```js
 const { Client, Intents, MessageEmbed } = require('discord.js');
@@ -141,7 +141,11 @@ client.once('ready', async () => {
 	const channel = client.channels.cache.get('123456789012345678');
 	try {
 		const webhooks = await channel.fetchWebhooks();
-		const webhook = webhooks.first();
+		const webhook = webhooks.find(wh => wh.token);
+
+		if (!webhook) {
+			return console.log('No webhook was found that I can use!');
+		}
 
 		await webhook.send({
 			content: 'Webhook test',