Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new packet recieve type: LED Blink Offset #274

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nullstalgia
Copy link
Contributor

Progresses (but does not close) issue 301 of the SlimeVR Server.

This allows the server to send a packet to the tracker with a uint32_t value that contains the delay before it should (re)start the normal blinking loop.

Used for syncing the blinks together, or set up an order in which trackers should blink with incrementing offsets.

@Eirenliel
Copy link
Member

Is this really necessary...

@nullstalgia
Copy link
Contributor Author

Absolutely necessary? No.

But it's something that myself and others have discussed in the discord before as a cute nice-to-have, and it's not taking up massive amount of resources on either the server or tracker side. I opened the issue in November of 2022 and since no one else took up the mantle (or shut it down), myself and Uriel were discussing it after another person was asking about it. We decided to make it a reality together, since I knew the ESP side better than the Kotlin side, and visa versa.

@unlogisch04 unlogisch04 added the Status: Blocked by other issue Progress cannot be made until linked issue is resolved label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Blocked by other issue Progress cannot be made until linked issue is resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants