-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added wifi dropdown to the wizzard #1033
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ZRock and I couldn't get it to work (it just falls back to the text field input, which I assume means no wifi network was found somehow). On Windows 11
Your computer did have wifi networks available? I'll check it on another computer. Also would a notice if it didn't find anything be a good addition or just bloat for the end user? |
I didn’t have wifi turned on, I’ll test again with it turned on tomorrow (Idk about ZRock). Didn’t think about the fact that Ethernet wouldn’t give any SSID, my bad ahah. I thought I did test with a SlimeVR tracker turned on and connected via Wifi tho, how does finding networks via “Connected slime tracker wifi scanning” work/how can I test that? As for a notice, I think it might just confuse users into thinking something is wrong when it’s not. |
idk why it autofilled but didn't show a dropdown on the first try, but I recorded that video to show that going from Other to a Wifi network in the dropdown will leave the Submit button disabled. Not sure how many wifi networks it's supposed to have in the dropdown, but it only showed the one I was connected to (which shouldn't be a problem, but I thought it'd also have the scanned available wifi networks) Another issue: it only shows the dropdown every other time: https://cdn.discordapp.com/attachments/823658497454374962/1248422134905311353/slimevr_emybDRyOrh.mp4?ex=66639b37&is=666249b7&hm=ee1909308e4b0df2895f96f7fd65a80778c048985b510a11947a05f1b2b6b93a& |
Fixed some bug where it wouldn't load or just partially load |
This works through the serial command: "GET WIFISCAN" Maybe a small loader icon could be nice to indicate it's working on something? |
btw i just checked and |
Alternative for windows would be to do a WlanScan and then a WlanGetAvailableNetworkList which sounds very fun |
This feature changes the wifi form in the setup wizzard.
It will find networks from:
Stubs have been put in place for linux and mac. These could possibly filled in with: https://github.com/booyaa/wifiscanner/tree/main
Although scanning via a slime tracker should always work.
This is my first contribution, please let me know if changes are required.