Merge pull request #27 from gene-pavlovsky/hide_no_description_targets

PluginUI.cs: optionally hide targets without a description.
SlavaRa · Apr 13, 2016 · f376e97 · f376e97
2 parents 10b9c64 + 78cbc3b
commit f376e97
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/AntPanel/PluginUI.cs b/AntPanel/PluginUI.cs
@@ -218,16 +218,35 @@ AntTreeNode GetBuildFileNode(string file)
                 Target = defaultTarget,
                 ToolTipText = description
             };
+            bool skipHiddenTargets = ((Settings)pluginMain.Settings).SkipHiddenTargets;
+            if (skipHiddenTargets)
+            {
+                // no-description targets should be hidden only if at least one target has a description
+                skipHiddenTargets = false;
+                foreach (XmlNode node in documentElement.ChildNodes)
+                {
+                    if (node.Name != "target") continue;
+                    XmlAttributeCollection attributes = node.Attributes;
+                    Debug.Assert(attributes != null, "attributes != null");
+                    if (!string.IsNullOrEmpty(attributes["description"]?.InnerText))
+                    {
+                        skipHiddenTargets = true;
+                        break;
+                    }
+                }
+            }
             foreach (XmlNode node in documentElement.ChildNodes)
             {
                 if (node.Name != "target") continue;
-                // skip private targets
+                // skip private and optionally hidden targets
                 XmlAttributeCollection attributes = node.Attributes;
                 Debug.Assert(attributes != null, "attributes != null");
                 XmlAttribute targetNameAttr = attributes["name"];
                 string targetName = targetNameAttr?.InnerText;
                 if (!string.IsNullOrEmpty(targetName) && (targetName[0] == '-'))
                     continue;
+                if (skipHiddenTargets && string.IsNullOrEmpty(attributes["description"]?.InnerText))
+                    continue;
                 AntTreeNode targetNode = GetBuildTargetNode(node, defaultTarget);
                 targetNode.File = file;
                 rootNode.Nodes.Add(targetNode);

diff --git a/AntPanel/Settings.cs b/AntPanel/Settings.cs
@@ -13,5 +13,9 @@ public class Settings
         [DefaultValue("")]
         [Editor(typeof(FolderNameEditor), typeof(UITypeEditor))]
         public string AntPath { get; set; }
+
+        [DisplayName("Hide no-description targets"), DefaultValue(false)]
+        [Description("Hide targets that don't have a description (unless all of the targets don't have one)")]
+        public Boolean SkipHiddenTargets { get; set; }
     }
 }