build: dont force CMAKE_OSX_ARCHITECTURES #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <[email protected]>
|
There was an error a while ago relating to this with GHA that required |
it is required for homebrew (as you can see in the related pr, we need to specify it for the macos sequoia build) |
|
Ok, so it looks like the x86 versions might be downright deprecated soon, so we can go all-in on ARM. |
|
@chenrui333 The Brew patch you applied will need to be removed in the next release, as the code it references no longer exists (there is no attempt to make a universal binary anymore) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seeing some build failure while bottling for macos sequoia, but since
CMAKE_OSX_ARCHITECTURESis forced, there is no way to override it.relates to Homebrew/homebrew-core#190600