add azure o3 mini #1711
Merged
add azure o3 mini #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add Azure O3 Mini support with new settings and configuration registration in `config.py` and `config_registry.py`. > > - **Settings**: > - Add `ENABLE_AZURE_O3_MINI` flag in `Settings` class in `config.py`. > - Add Azure O3 Mini related settings: `AZURE_O3_MINI_DEPLOYMENT`, `AZURE_O3_MINI_API_KEY`, `AZURE_O3_MINI_API_BASE`, `AZURE_O3_MINI_API_VERSION`. > - **Configuration**: > - Register `AZURE_OPENAI_O3_MINI` configuration in `LLMConfigRegistry` in `config_registry.py`. > - Set `litellm_params` with `api_base`, `api_key`, `api_version`, and model info for Azure O3 Mini. > - Configure with `supports_vision=False`, `add_assistant_prefix=False`, `max_completion_tokens=16384`, `temperature=None`, `reasoning_effort="low"`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for e65e77213e2e9494722ea7341cec204e01f0f699. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 197cc60 in 34 seconds
More details
- Looked at
61lines of code in2files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. skyvern/config.py:106
- Draft comment:
Add AZURE_O3_MINI settings. Consider adding a brief comment to explain these new settings for clarity and consistency with other Azure provider configs. - Reason this comment was not posted:
Confidence changes required:33%
None
2. skyvern/forge/sdk/api/llm/config_registry.py:282
- Draft comment:
New AZURE_OPENAI_O3_MINI registration looks consistent. Ensure the naming and parameter choices (like 'reasoning_effort: low' and temperature=None) align with intended behavior. - Reason this comment was not posted:
Confidence changes required:33%
None
3. skyvern/config.py:105
- Draft comment:
Add documentation for the new AZURE_O3_MINI settings block (flag and env vars) for clarity. - Reason this comment was not posted:
Confidence changes required:33%
None
4. skyvern/forge/sdk/api/llm/config_registry.py:282
- Draft comment:
Verify that 'reasoning_effort' being set to 'low' for AZURE_OPENAI_O3_MINI is intentional and aligns with expected behavior. - Reason this comment was not posted:
Confidence changes required:33%
None
Workflow ID: wflow_3XSmxuHe4MyTRNvo
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 197cc60 in 35 seconds
More details
- Looked at
61lines of code in2files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. skyvern/config.py:105
- Draft comment:
Ensure documentation for new ENABLE_AZURE_O3_MINI flag and its related env vars is added for clarity. - Reason this comment was not posted:
Comment did not seem useful.
2. skyvern/forge/sdk/api/llm/config_registry.py:282
- Draft comment:
Confirm consistency of reasoning_effort ('low') compared to similar configurations (e.g., OPENAI_O3_MINI) and verify naming conventions. - Reason this comment was not posted:
Marked as duplicate.
3. skyvern/config.py:106
- Draft comment:
Consider adding a brief inline comment for the new ENABLE_AZURE_O3_MINI flag and its related settings to clarify its purpose. - Reason this comment was not posted:
Confidence changes required:20%
None
4. skyvern/forge/sdk/api/llm/config_registry.py:282
- Draft comment:
The new AZURE_OPENAI_O3_MINI config sets reasoning_effort to 'low' while the similar OPENAI_O3_MINI config uses 'high'. Confirm if this difference is intentional. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_AZKb0GRb6CEWZWdB
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
LawyZheng
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add support for Azure O3 Mini model configuration in
skyvernwith new settings and registration logic.AZURE_O3_MINImodel inconfig_registry.py.AZURE_O3_MINIconfiguration withLLMConfigRegistryifENABLE_AZURE_O3_MINIis true.ENABLE_AZURE_O3_MINI,AZURE_O3_MINI_DEPLOYMENT,AZURE_O3_MINI_API_KEY,AZURE_O3_MINI_API_BASE,AZURE_O3_MINI_API_VERSIONtoSettingsinconfig.py.This description was created by
for 197cc60. It will automatically update as commits are pushed.