add get page video timeout #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add timeout for retrieving video paths in `set_working_page()` of `BrowserState` class, logging on timeout. > > - **Behavior**: > - Adds timeout for `page.video.path()` in `set_working_page()` in `BrowserState` class. > - Logs a message and skips exception on timeout. > - **Configuration**: > - Uses `settings.BROWSER_ACTION_TIMEOUT_MS` for timeout duration. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for affdf31410fa5014257bcd936917613d3d3d5276. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on c803c8c in 24 seconds
More details
- Looked at
29lines of code in1files - Skipped
0files when reviewing. - Skipped posting
5drafted comments based on config settings.
1. skyvern/webeye/browser_factory.py:483
- Draft comment:
Consider if an info-level log is enough here. Also, handle other possible exceptions from page.video.path() to avoid silent failures. - Reason this comment was not posted:
Confidence changes required:50%
None
2. skyvern/webeye/browser_factory.py:494
- Draft comment:
Repeating similar try/except block. Consider refactoring to eliminate duplication and review log level; also check if skipping timeout is desired behavior. - Reason this comment was not posted:
Confidence changes required:50%
None
3. skyvern/webeye/browser_factory.py:483
- Draft comment:
Consider logging additional context (e.g., the video artifact index) when a timeout occurs to facilitate debugging. - Reason this comment was not posted:
Confidence changes required:33%
None
4. skyvern/webeye/browser_factory.py:494
- Draft comment:
Duplicate timeout-handling logic. Consider refactoring this into a helper function to reduce repetition. - Reason this comment was not posted:
Confidence changes required:33%
None
5. skyvern/webeye/browser_factory.py:484
- Draft comment:
Note: asyncio.timeout is available in Python 3.11+. Ensure this requirement is acceptable for the project or consider using asyncio.wait_for for earlier versions. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_OFMdHibhQmeMhKkJ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
LawyZheng
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to c803c8c in 56 seconds
More details
- Looked at
29lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. skyvern/webeye/browser_factory.py:483
- Draft comment:
Ensure asyncio.timeout is supported (Python 3.11+). Consider using asyncio.wait_for for broader compatibility. - Reason this comment was not posted:
Marked as duplicate.
2. skyvern/webeye/browser_factory.py:494
- Draft comment:
The try/except block for page.video.path() is duplicated. Consider refactoring into a helper to reduce code duplication. - Reason this comment was not posted:
Marked as duplicate.
3. skyvern/webeye/browser_factory.py:494
- Draft comment:
Duplicate timeout wrapper for page.video.path() detected. Refactor this pattern into a reusable helper to simplify maintenance. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_rDfOA5FysSLEJ8TN
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -480,14 +480,22 @@ async def set_working_page(self, page: Page | None, index: int = 0) -> None: | |||
| return | |||
| if len(self.browser_artifacts.video_artifacts) > index: | |||
| if self.browser_artifacts.video_artifacts[index].video_path is None: | |||
| self.browser_artifacts.video_artifacts[index].video_path = await page.video.path() | |||
| try: | |||
| async with asyncio.timeout(settings.BROWSER_ACTION_TIMEOUT_MS / 1000): | |||
There was a problem hiding this comment.
Good use of asyncio.timeout to guard video retrieval. Consider extracting this timeout logic into a helper function to reduce duplication and review if INFO logging is the appropriate level for a timeout event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add timeout for retrieving page video path in
set_working_page()inbrowser_factory.py, logging on timeout and skipping exception.page.video.path()inset_working_page()inbrowser_factory.py.asyncio.TimeoutErrorand skips exception.settings.BROWSER_ACTION_TIMEOUT_MSfor timeout duration.This description was created by
for c803c8c. It will automatically update as commits are pushed.