Add workflow templates endpoint #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add new endpoint `/workflows/templates` in `agent_protocol.py` to retrieve workflow templates with statuses `published` or `draft`. > > - **New Endpoint**: > - Adds `get_workflow_templates()` function in `agent_protocol.py` to retrieve workflow templates. > - Endpoint `/workflows/templates` returns a list of `Workflow` objects with statuses `published` or `draft`. > - Handles case where no global workflows are found by returning an empty list. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 626639a51e49f19f9bdf1b957c4682d9bc589254. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 3f74820 in 10 seconds
More details
- Looked at
27lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/routes/agent_protocol.py:946
- Draft comment:
Consider adding analytics capture for the new endpoint to maintain consistency with other endpoints. - Reason this comment was not posted:
Confidence changes required:50%
The new endpoint lacks analytics capture, which is inconsistent with other endpoints.
Workflow ID: wflow_3FxA9qnKsmaz1iwB
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 3f74820 in 14 seconds
More details
- Looked at
27lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/routes/agent_protocol.py:946
- Draft comment:
Consider adding analytics capture for theget_workflow_templatesendpoint to maintain consistency with other endpoints. - Reason this comment was not posted:
Confidence changes required:50%
The new endpointget_workflow_templatesis added correctly, but it lacks analytics capture which is present in other similar endpoints. This could be important for tracking usage and debugging.
Workflow ID: wflow_Ox3BxyoNgtZjeB1I
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
msalihaltun
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
/workflows/templatesendpoint inagent_protocol.pyto retrieve workflow templates withpublishedanddraftstatuses.get_workflow_templates()function inagent_protocol.pyto retrieve workflow templates./workflows/templatesreturns a list ofWorkflowobjects.app.STORAGE.retrieve_global_workflows().publishedanddraftusingapp.WORKFLOW_SERVICE.get_workflows_by_permanent_ids().This description was created by
for 3f74820. It will automatically update as commits are pushed.