Change workflow queries to use API to get global workflows

[wintonzheng]

Important

Refactor to use API-based global workflow queries with useGlobalWorkflowsQuery, removing reliance on environment variables.

• Behavior:
  • Replaces environment variable globalWorkflowIds with API-based query using useGlobalWorkflowsQuery.
  • Updates WorkflowPage, WorkflowTitle, WorkflowHeader, and other components to use useGlobalWorkflowsQuery for global workflow checks.
• Hooks:
  • Adds useGlobalWorkflowsQuery in useGlobalWorkflowsQuery.ts to fetch global workflows with template=true.
  • Refactors useWorkflowQuery, useWorkflowRunQuery, useWorkflowRunTimelineQuery, and useWorkflowRunsQuery to use useGlobalWorkflowsQuery for determining global workflows.
• Misc:
  • Removes globalWorkflowIds from env.ts.

^{This description was created by for e378525. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Incremental review on e378525 in 37 seconds

More details

• Looked at 404 lines of code in 9 files
• Skipped 0 files when reviewing.
• Skipped posting 7 drafted comments based on config settings.

1. skyvern-frontend/src/routes/workflows/hooks/useGlobalWorkflowsQuery.ts:21

• Draft comment:
  Consider adding a loading state check for globalWorkflows to ensure it's fully loaded before being used in other components or hooks. This can prevent potential null or undefined errors.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The use of globalWorkflows in multiple hooks and components without checking if it's loaded can lead to potential null or undefined errors. It's better to handle the loading state explicitly.

2. skyvern-frontend/src/routes/workflows/WorkflowTitle.tsx:15

• Draft comment:
  Ensure that globalWorkflows is fully loaded before using it. Consider handling the loading state explicitly to avoid potential null or undefined errors.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The useGlobalWorkflowsQuery is used in multiple places, and its loading state is not consistently checked. This can lead to potential issues if the data is not yet available.

3. skyvern-frontend/src/routes/workflows/editor/WorkflowHeader.tsx:34

• Draft comment:
  Ensure that globalWorkflows is fully loaded before using it. Consider handling the loading state explicitly to avoid potential null or undefined errors.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The useGlobalWorkflowsQuery is used in multiple places, and its loading state is not consistently checked. This can lead to potential issues if the data is not yet available.

4. skyvern-frontend/src/routes/workflows/hooks/useWorkflowQuery.ts:11

• Draft comment:
  Ensure that globalWorkflows is fully loaded before using it. Consider handling the loading state explicitly to avoid potential null or undefined errors.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The useGlobalWorkflowsQuery is used in multiple places, and its loading state is not consistently checked. This can lead to potential issues if the data is not yet available.

5. skyvern-frontend/src/routes/workflows/hooks/useWorkflowRunQuery.ts:15

• Draft comment:
  Ensure that globalWorkflows is fully loaded before using it. Consider handling the loading state explicitly to avoid potential null or undefined errors.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The useGlobalWorkflowsQuery is used in multiple places, and its loading state is not consistently checked. This can lead to potential issues if the data is not yet available.

6. skyvern-frontend/src/routes/workflows/hooks/useWorkflowRunTimelineQuery.ts:13

• Draft comment:
  Ensure that globalWorkflows is fully loaded before using it. Consider handling the loading state explicitly to avoid potential null or undefined errors.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The useGlobalWorkflowsQuery is used in multiple places, and its loading state is not consistently checked. This can lead to potential issues if the data is not yet available.

7. skyvern-frontend/src/routes/workflows/hooks/useWorkflowRunsQuery.ts:25

• Draft comment:
  Ensure that globalWorkflows is fully loaded before using it. Consider handling the loading state explicitly to avoid potential null or undefined errors.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The useGlobalWorkflowsQuery is used in multiple places, and its loading state is not consistently checked. This can lead to potential issues if the data is not yet available.

Workflow ID: wflow_Hs0fIoYmOlcnyhKP

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to e378525 in 1 minute and 19 seconds

More details

• Looked at 404 lines of code in 9 files
• Skipped 0 files when reviewing.
• Skipped posting 6 drafted comments based on config settings.

1. skyvern-frontend/src/routes/workflows/WorkflowTitle.tsx:15

• Draft comment:
  Consider using a context or a higher-level component to provide globalWorkflows to avoid multiple components independently fetching the same data. This can improve performance by reducing redundant API calls.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The use of useGlobalWorkflowsQuery in multiple components and hooks is consistent and seems to replace the previous method of checking global workflow IDs. However, there is a potential performance issue due to multiple components independently fetching the same data.

2. skyvern-frontend/src/routes/workflows/editor/WorkflowHeader.tsx:34

• Draft comment:
  Consider using a context or a higher-level component to provide globalWorkflows to avoid multiple components independently fetching the same data. This can improve performance by reducing redundant API calls.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The use of useGlobalWorkflowsQuery in multiple components and hooks is consistent and seems to replace the previous method of checking global workflow IDs. However, there is a potential performance issue due to multiple components independently fetching the same data.

3. skyvern-frontend/src/routes/workflows/hooks/useWorkflowQuery.ts:11

• Draft comment:
  Consider using a context or a higher-level component to provide globalWorkflows to avoid multiple components independently fetching the same data. This can improve performance by reducing redundant API calls.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The use of useGlobalWorkflowsQuery in multiple components and hooks is consistent and seems to replace the previous method of checking global workflow IDs. However, there is a potential performance issue due to multiple components independently fetching the same data.

4. skyvern-frontend/src/routes/workflows/hooks/useWorkflowRunQuery.ts:15

• Draft comment:
  Consider using a context or a higher-level component to provide globalWorkflows to avoid multiple components independently fetching the same data. This can improve performance by reducing redundant API calls.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The use of useGlobalWorkflowsQuery in multiple components and hooks is consistent and seems to replace the previous method of checking global workflow IDs. However, there is a potential performance issue due to multiple components independently fetching the same data.

5. skyvern-frontend/src/routes/workflows/hooks/useWorkflowRunTimelineQuery.ts:13

• Draft comment:
  Consider using a context or a higher-level component to provide globalWorkflows to avoid multiple components independently fetching the same data. This can improve performance by reducing redundant API calls.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The use of useGlobalWorkflowsQuery in multiple components and hooks is consistent and seems to replace the previous method of checking global workflow IDs. However, there is a potential performance issue due to multiple components independently fetching the same data.

6. skyvern-frontend/src/routes/workflows/hooks/useWorkflowRunsQuery.ts:25

• Draft comment:
  Consider using a context or a higher-level component to provide globalWorkflows to avoid multiple components independently fetching the same data. This can improve performance by reducing redundant API calls.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The use of useGlobalWorkflowsQuery in multiple components and hooks is consistent and seems to replace the previous method of checking global workflow IDs. However, there is a potential performance issue due to multiple components independently fetching the same data.

Workflow ID: wflow_7oyLcxmMnGA9J6za

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.