Start workflow runs instantly instead of showing a notification which… #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' … can redirect <!-- ELLIPSIS_HIDDEN --> ---- > [!IMPORTANT] > Directly navigates to workflow overview page after starting a workflow run, removing the notification action. > > - **Behavior**: > - Directly navigates to workflow overview page after starting a workflow run in `RunWorkflowForm`. > - Removes `ToastAction` notification that previously redirected to the overview page. > - **Navigation**: > - Uses `useNavigate` from `react-router-dom` to handle redirection in `RunWorkflowForm`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for a8e98fcd5a8d6a140043607b6bf91b17fa769e34. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 1e4d801 in 27 seconds
More details
- Looked at
50lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx:17
- Draft comment:
Remove unused importToastActionsince it's no longer used in the code. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_cqiD0uwuGDs0xtfp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 1e4d801 in 25 seconds
More details
- Looked at
50lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx:106
- Draft comment:
Consider usinggetRunWorkflowRequestBodydirectly inonSubmitto avoid duplicating the parameter parsing logic. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_P5joTGZgq7JGTXcK
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
msalihaltun
approved these changes
Jan 31, 2025
msalihaltun
deleted the
salih/redirect-instantly-to-workflow-run-instead-of-notification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… can redirect
Important
RunWorkflowFormnow navigates directly to the workflow overview page upon successful run initiation, removing the notification action.RunWorkflowForminRunWorkflowForm.tsxnow navigates directly to the workflow overview page upon successful run initiation, removing the notification action.useNavigateinstead ofLinkfor redirection.ToastActionimport from@radix-ui/react-toastas it's no longer used.This description was created by
for 1e4d801. It will automatically update as commits are pushed.