Improve wait time input #1681
Merged
Improve wait time input #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Improves wait time input handling in `WaitNode` by using a standard input component, changing data type to string, and adding validation. > > - **Behavior**: > - Replaces `WorkflowBlockInput` with `Input` in `WaitNode.tsx` for wait time input. > - Changes `waitInSeconds` type from `number` to `string` in `WaitNodeData`. > - Adds validation for `waitInSeconds` to ensure it is a numeric string in `getWorkflowErrors()`. > - **Data Handling**: > - Converts `waitInSeconds` to string in `convertToNode()` and back to number in `getWorkflowBlock()`. > - **Imports**: > - Adds `isWaitNode` import in `workflowEditorUtils.ts`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 8ac2a6377ed74165647b56a4984530efdf833162. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 45b1c98 in 56 seconds
More details
- Looked at
108lines of code in3files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/WaitNode/types.ts:5
- Draft comment:
Consider convertingwaitInSecondsto a number when used in calculations or logic to avoid potential type issues. - Reason this comment was not posted:
Marked as duplicate.
2. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:965
- Draft comment:
EnsurewaitInSecondsis consistently converted to a number when used in logic or calculations.
wait_sec: parseInt(node.data.waitInSeconds, 10),
- Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_HMhyoNp20r5rCkt6
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
skyvern-frontend/src/routes/workflows/editor/nodes/WaitNode/WaitNode.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 45b1c98 in 1 minute and 44 seconds
More details
- Looked at
108lines of code in3files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/WaitNode/types.ts:5
- Draft comment:
EnsurewaitInSecondsis consistently converted to a number where necessary, such as when using it in calculations or logic that requires a number. - Reason this comment was not posted:
Comment did not seem useful.
2. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:965
- Draft comment:
EnsurewaitInSecondsis converted to a number wherever it is used in a numeric context, not just ingetWorkflowBlock. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_Q0OC9dkX7NzODp8E
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
skyvern-frontend/src/routes/workflows/editor/nodes/WaitNode/WaitNode.tsx
Show resolved
Hide resolved
msalihaltun
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Improves wait time input handling in
WaitNodeby changing input type to string and adding numeric validation.WorkflowBlockInputwithInputinWaitNode.tsxfor wait time input.waitInSecondstype fromnumbertostringintypes.ts.getWorkflowErrors()inworkflowEditorUtils.ts.waitInSecondsto string inconvertToNode()inworkflowEditorUtils.ts.waitInSecondsback to number ingetWorkflowBlock()inworkflowEditorUtils.ts.isWaitNodeinworkflowEditorUtils.ts.This description was created by
for 45b1c98. It will automatically update as commits are pushed.