Put success/failure indicators in block items of timelines

[wintonzheng]

Important

Add success and failure indicators to timeline block items and adjust scroll behavior in WorkflowRunTimelineBlockItem.tsx, ActionCard.tsx, and ThoughtCard.tsx.

• UI Enhancements:
  • Add success (CheckCircledIcon) and failure (CrossCircledIcon) indicators in WorkflowRunTimelineBlockItem.tsx for block statuses.
  • Add success and failure indicators in ActionCard.tsx based on action status.
• Behavior Changes:
  • Change scrollIntoView block option from center to start in ActionCard.tsx, ThoughtCard.tsx, and WorkflowRunTimelineBlockItem.tsx for smoother scrolling.
• Misc:
  • Import CheckCircledIcon and CrossCircledIcon in WorkflowRunTimelineBlockItem.tsx and ActionCard.tsx.

^{This description was created by for e43599a. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to e43599a in 21 seconds

More details

• Looked at 120 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. skyvern-frontend/src/routes/workflows/workflowRun/ActionCard.tsx:22

• Draft comment:
  The change from block: "center" to block: "start" is consistent with the PR's intent to adjust scroll behavior. Ensure this aligns with the desired UX.
• Reason this comment was not posted:
  Confidence changes required: 20%
  The use of scrollIntoView with block: "start" is consistent across multiple files. This change is intentional and aligns with the PR's goal to adjust the scroll behavior. No issues here.

2. skyvern-frontend/src/routes/workflows/workflowRun/ThoughtCard.tsx:18

• Draft comment:
  The change from block: "center" to block: "start" is consistent with the PR's intent to adjust scroll behavior. Ensure this aligns with the desired UX.
• Reason this comment was not posted:
  Confidence changes required: 20%
  The use of scrollIntoView with block: "start" is consistent across multiple files. This change is intentional and aligns with the PR's goal to adjust the scroll behavior. No issues here.

3. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowRunTimelineBlockItem.tsx:64

• Draft comment:
  The change from block: "center" to block: "start" is consistent with the PR's intent to adjust scroll behavior. Ensure this aligns with the desired UX.
• Reason this comment was not posted:
  Confidence changes required: 20%
  The use of scrollIntoView with block: "start" is consistent across multiple files. This change is intentional and aligns with the PR's goal to adjust the scroll behavior. No issues here.

4. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowRunTimelineBlockItem.tsx:71

• Draft comment:
  Consider refactoring the logic for determining showSuccessIndicator and showFailureIndicator into a utility function to avoid repetition and improve maintainability. This logic is also present in ActionCard.tsx.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR introduces success and failure indicators using icons. This is a new feature and seems to be implemented correctly. However, the logic for determining success and failure is repeated in multiple places.

Workflow ID: wflow_LkfiykRVi3caCVtM

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on e43599a in 23 seconds

More details

• Looked at 120 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. skyvern-frontend/src/routes/workflows/workflowRun/ActionCard.tsx:22

• Draft comment:
  Ensure that changing block: "center" to block: "start" in scrollIntoView aligns with the intended user experience, as this affects how elements are scrolled into view.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The use of scrollIntoView with block: "start" is consistent across multiple files. This change is intentional and aligns with the PR's goal to adjust the scroll behavior.

2. skyvern-frontend/src/routes/workflows/workflowRun/ThoughtCard.tsx:18

• Draft comment:
  Ensure that changing block: "center" to block: "start" in scrollIntoView aligns with the intended user experience, as this affects how elements are scrolled into view.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The use of scrollIntoView with block: "start" is consistent across multiple files. This change is intentional and aligns with the PR's goal to adjust the scroll behavior.

3. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowRunTimelineBlockItem.tsx:64

• Draft comment:
  Ensure that changing block: "center" to block: "start" in scrollIntoView aligns with the intended user experience, as this affects how elements are scrolled into view.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The use of scrollIntoView with block: "start" is consistent across multiple files. This change is intentional and aligns with the PR's goal to adjust the scroll behavior.

Workflow ID: wflow_BcVTnqicHlt7mj2o

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.