Frontend for complete if empty #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Adds `completeIfEmpty` feature to LoopNode, allowing it to complete if loop value is empty, with UI and data model updates. > > - **Behavior**: > - Adds a `Checkbox` in `LoopNode.tsx` to toggle `completeIfEmpty` for LoopNode. > - Updates `LoopNodeData` in `types.ts` to include `completeIfEmpty` boolean. > - Modifies `convertToNode()` and `getWorkflowBlocksUtil()` in `workflowEditorUtils.ts` to handle `completeIfEmpty`. > - **Data Models**: > - Adds `completeIfEmpty` to `ForLoopBlock` in `workflowTypes.ts`. > - Updates `ForLoopBlockYAML` in `workflowYamlTypes.ts` to include `complete_if_empty`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 9b52913061d2f101b0a74451338bf6340aa66552. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 2c9b855 in 15 seconds
More details
- Looked at
121lines of code in5files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:147
- Draft comment:
Verify the change in margin from 200 to 225 to ensure it doesn't cause layout issues. - Reason this comment was not posted:
Confidence changes required:50%
The margin change from 200 to 225 in the layout function might affect the overall layout of the nodes. This change should be verified to ensure it doesn't cause any unintended layout issues.
Workflow ID: wflow_8aeFvCYrqRLLPrhw
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 2c9b855 in 20 seconds
More details
- Looked at
121lines of code in5files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:1633
- Draft comment:
Ensure 'complete_if_empty' is set to a default value in case it's undefined to prevent potential issues during YAML conversion. - Reason this comment was not posted:
Confidence changes required:50%
The PR introduces a new feature 'Complete if Empty' for LoopNode, which is reflected in the UI and data structures. The changes are consistent across the codebase, ensuring that the new feature is integrated into the existing workflow system. However, there is a minor issue with the default value of 'complete_if_empty' in the YAML conversion function.
Workflow ID: wflow_gagyOrXjDRBMqJ49
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
msalihaltun
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds a feature to LoopNode allowing completion if loop value is empty, with UI, data model, and workflow logic updates.
CheckboxinLoopNode.tsxto togglecompleteIfEmptyfor loop nodes.LoopNodeDataintypes.tsto includecompleteIfEmptyboolean.convertToNode()andgetWorkflowBlocksUtil()inworkflowEditorUtils.tsto handlecompleteIfEmpty.complete_if_emptytoForLoopBlockinworkflowTypes.tsandForLoopBlockYAMLinworkflowYamlTypes.ts.marginyinlayout()inworkflowEditorUtils.tsfrom 200 to 225.This description was created by
for 2c9b855. It will automatically update as commits are pushed.