Remove TOTP URL from UI #1674
Merged
Remove TOTP URL from UI #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Remove `totpVerificationUrl` field from task forms and workflow nodes to simplify UI and data handling. > > - **Behavior**: > - Removed `totpVerificationUrl` field from task creation forms in `CreateNewTaskForm.tsx`, `CreateNewTaskFormPage.tsx`, and `SavedTaskForm.tsx`. > - Removed `totpVerificationUrl` handling from retry task logic in `RetryTask.tsx`. > - Removed `totpVerificationUrl` from workflow editor nodes: `ActionNode.tsx`, `FileDownloadNode.tsx`, `LoginNode.tsx`, `NavigationNode.tsx`, and `TaskNode.tsx`. > - **Schemas**: > - Removed `totpVerificationUrl` from `createNewTaskFormSchemaBase` in `taskFormTypes.ts`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for e29d1d5ce67e4378a0b79d627d552334bc35300f. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 84c92a6 in 32 seconds
More details
- Looked at
299lines of code in10files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_thfITfRBsmozpjRz
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 84c92a6 in 48 seconds
More details
- Looked at
299lines of code in10files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_TlW7zFMDaPEFNPGi
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
msalihaltun
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Remove
totpVerificationUrlfield from task creation forms and workflow nodes in the UI.totpVerificationUrlfield from task creation forms inCreateNewTaskForm.tsx,CreateNewTaskFormPage.tsx, andSavedTaskForm.tsx.totpVerificationUrlhandling from workflow nodes inActionNode.tsx,FileDownloadNode.tsx,LoginNode.tsx,NavigationNode.tsx, andTaskNode.tsx.totpVerificationUrlfromcreateNewTaskFormSchemaBaseintaskFormTypes.ts.totpVerificationUrlinCreateNewTaskForm.tsx,CreateNewTaskFormPage.tsx, andSavedTaskForm.tsx.This description was created by
for 84c92a6. It will automatically update as commits are pushed.