Add job agent #1672
Merged
Add job agent #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add job application agent with new page, file upload, and run history tracking, updating navigation and environment configurations. > > - **New Features**: > - Add `JobsPage` in `router.tsx` for job applications, allowing users to upload resumes and submit job URLs. > - Implement `JobAgentFileUpload` for handling file uploads with a 10MB limit. > - Add `JobsRunHistory` to track job application runs. > - **Routing and Navigation**: > - Update `SideNav.tsx` to enable the "Jobs" link. > - Replace `ComingSoonPage` with `JobsPage` in `router.tsx`. > - **Environment and Configuration**: > - Add `JOB_APPLICATION_WORKFLOW_WPID` to `constants.ts` for workflow identification. > - Introduce `globalWorkflowIds` in `env.ts` to manage global workflows. > - **Miscellaneous**: > - Remove unused `statusDropdownItems` in `FormsRunHistory.tsx`. > - Update `FileUpload.tsx` to include new icons and reset functionality. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 686cd8507f941cd7eba78fa8c9956f8123269cf3. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add job application agent with new page, file upload, and run history tracking, updating navigation and environment configurations. > > - **New Features**: > - Add `JobsPage` in `router.tsx` for job applications, allowing users to upload resumes and submit job URLs. > - Implement `JobAgentFileUpload` for handling file uploads with a 10MB limit. > - Add `JobsRunHistory` to track job application runs. > - **Routing and Navigation**: > - Update `SideNav.tsx` to enable the "Jobs" link. > - Replace `ComingSoonPage` with `JobsPage` in `router.tsx`. > - **Environment and Configuration**: > - Add `JOB_APPLICATION_WORKFLOW_WPID` to `constants.ts` for workflow identification. > - Introduce `globalWorkflowIds` in `env.ts` to manage global workflows. > - **Miscellaneous**: > - Remove unused `statusDropdownItems` in `FormsRunHistory.tsx`. > - Update `FileUpload.tsx` to include new icons and reset functionality. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 686cd8507f941cd7eba78fa8c9956f8123269cf3. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 77908a2 in 13 seconds
More details
- Looked at
236lines of code in7files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/util/env.ts:36
- Draft comment:
Consider logging a warning when JSON parsing fails ingetGlobalWorkflowIdsto aid in debugging. - Reason this comment was not posted:
Confidence changes required:50%
The code ingetGlobalWorkflowIdsfunction is parsing a JSON string from an environment variable. If the parsing fails, it returns an empty array, which is a safe fallback. However, it would be beneficial to log a warning when the parsing fails to help with debugging.
Workflow ID: wflow_4FOghNR9Lfivt9XC
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 77908a2 in 1 minute and 20 seconds
More details
- Looked at
266lines of code in8files - Skipped
0files when reviewing. - Skipped posting
7drafted comments based on config settings.
1. skyvern-frontend/src/components/FileUpload.tsx:115
- Draft comment:
Redundant comment:// redundant check for ts compilercan be removed for clarity. - Reason this comment was not posted:
Confidence changes required:10%
The code inskyvern-frontend/src/components/FileUpload.tsxhas a redundant comment that can be removed for clarity.
2. skyvern-frontend/src/routes/workflows/WorkflowPage.tsx:53
- Draft comment:
Consider refactoring theisGlobalWorkflowcheck into a utility function as it is repeated in multiple files. - Reason this comment was not posted:
Confidence changes required:30%
The code inskyvern-frontend/src/routes/workflows/WorkflowPage.tsxhas a potential issue with theisGlobalWorkflowcheck. It is repeated in multiple files and can be refactored into a utility function for better maintainability.
3. skyvern-frontend/src/routes/workflows/hooks/useWorkflowQuery.ts:17
- Draft comment:
Consider refactoring theisGlobalWorkflowcheck into a utility function as it is repeated in multiple files. - Reason this comment was not posted:
Confidence changes required:30%
The code inskyvern-frontend/src/routes/workflows/hooks/useWorkflowQuery.tshas a potential issue with theisGlobalWorkflowcheck. It is repeated in multiple files and can be refactored into a utility function for better maintainability.
4. skyvern-frontend/src/routes/workflows/hooks/useWorkflowRunQuery.ts:20
- Draft comment:
Consider refactoring theisGlobalWorkflowcheck into a utility function as it is repeated in multiple files. - Reason this comment was not posted:
Confidence changes required:30%
The code inskyvern-frontend/src/routes/workflows/hooks/useWorkflowRunQuery.tshas a potential issue with theisGlobalWorkflowcheck. It is repeated in multiple files and can be refactored into a utility function for better maintainability.
5. skyvern-frontend/src/routes/workflows/hooks/useWorkflowRunTimelineQuery.ts:19
- Draft comment:
Consider refactoring theisGlobalWorkflowcheck into a utility function as it is repeated in multiple files. - Reason this comment was not posted:
Confidence changes required:30%
The code inskyvern-frontend/src/routes/workflows/hooks/useWorkflowRunTimelineQuery.tshas a potential issue with theisGlobalWorkflowcheck. It is repeated in multiple files and can be refactored into a utility function for better maintainability.
6. skyvern-frontend/src/routes/workflows/editor/WorkflowHeader.tsx:34
- Draft comment:
Consider refactoring theisGlobalWorkflowcheck into a utility function as it is repeated in multiple files. - Reason this comment was not posted:
Confidence changes required:30%
The code inskyvern-frontend/src/routes/workflows/editor/WorkflowHeader.tsxhas a potential issue with theisGlobalWorkflowcheck. It is repeated in multiple files and can be refactored into a utility function for better maintainability.
7. skyvern/forge/sdk/workflow/models/block.py:2106
- Draft comment:
Remove or address the commented-out section in theexecutefunction if not needed. - Reason this comment was not posted:
Confidence changes required:20%
Inskyvern/forge/sdk/workflow/models/block.py, theexecutefunction in theTaskV2Blockclass has a redundant commented-out section that should be removed or addressed if not needed.
Workflow ID: wflow_IOeKozrQadeilnal
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
msalihaltun
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 66d2a21 in 26 seconds
More details
- Looked at
30lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/models/block.py:52
- Draft comment:
ProxyLocationis still used in the code but has been removed from the imports. Re-add the import statement forProxyLocation. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_p9x7oDl7qzXiPAeg
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds global workflow handling by checking against
globalWorkflowIdsand updates UI components for better file management.globalWorkflowIdsinenv.tsto manage global workflows.WorkflowPage.tsx,WorkflowHeader.tsx,useWorkflowQuery.ts,useWorkflowRunQuery.ts, anduseWorkflowRunTimelineQuery.ts.template=trueparameter for global workflows in API requests.WorkflowHeader.tsxfor global workflows.Cross2IconandFileIcontoFileUpload.tsxfor better file management UI.FileUpload.tsxfor improved user experience.This description was created by
for 66d2a21. It will automatically update as commits are pushed.