Add Bitwarden to Dockerfile #1562
Merged
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 5428242 in 43 seconds
More details
- Looked at
30lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. Dockerfile:16
- Draft comment:
Consider addingapt-get updatebeforeapt-get installto ensure the package list is up-to-date. Also, addrm -rf /var/lib/apt/lists/*afterapt-get cleanto reduce image size. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_3ykUsrfLK0XLQBaT
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
wintonzheng
approved these changes
Jan 16, 2025
Inno-ooshot
reviewed
Jan 16, 2025
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 61246c7 in 45 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_N1sJxVvay7YmHY7F
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -13,7 +13,26 @@ COPY --from=requirements-stage /tmp/requirements.txt /app/requirements.txt | |||
| RUN pip install --no-cache-dir --upgrade -r requirements.txt | |||
| RUN playwright install-deps | |||
| RUN playwright install | |||
| RUN apt-get install -y xauth x11-apps netpbm && apt-get clean | |||
| RUN apt-get install -y xauth x11-apps netpbm curl && apt-get clean | |||
There was a problem hiding this comment.
Consider adding rm -rf /var/lib/apt/lists/* after apt-get clean to free up space by removing package lists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add Bitwarden CLI installation to Dockerfile with Node.js setup using nvm.
curltoapt-get installcommand.nvmenvironment variables and installnvm.v20.12.2and npm usingnvm.PATH.2024.9.0using npm.This description was created by
for 61246c7. It will automatically update as commits are pushed.