Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unused import / variable warnings #4

Open
wants to merge 2 commits into
base: offseason-comp
Choose a base branch
from

Conversation

megamaz
Copy link

@megamaz megamaz commented Oct 14, 2022

90% of the warnings were from unused variables and unused imports, there were over 100. It did not take that long to remove them.

This may or may not have broken the bot or some of the code idk, I didn't test it lmao

the other warnings were from deprecated methods or imports. I don't know WPILib well enough to be able to replace it with a non-deprecated version so I just added a FIXME

kinda just realized I may or may not have changed some stuff inside the lib directory, but since these were still warning removal and / or comment additions for deprecated libraries I think it should be fine.

@megamaz
Copy link
Author

megamaz commented Nov 4, 2022

since offseason-comp got new warnings I decided to remove those too
it's really not that hard to not have that many warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant