Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency check task #16

Merged
merged 40 commits into from
Mar 2, 2020
Merged

Dependency check task #16

merged 40 commits into from
Mar 2, 2020

Conversation

CloudPlatformer
Copy link
Contributor

Build task to identify vulnerable dependencies.

Uses the OWASP Dependency Check CLI tool:
https://owasp.org/www-project-dependency-check/
https://jeremylong.github.io/DependencyCheck/dependency-check-cli/index.html

Sends the results to log analytics for visibility in grafana.

chelnak and others added 30 commits January 29, 2020 19:54
* Exclude no console rule
* Correct eslint errors, move util functions in to runtime and handle asyncs better
* Add a utility helper
* Add some local debugging stuff
* Start migrating away from request module [Test for http]
* Initial commit for mock task runner

* Fix path building for taskrunner

* Fix how we build paths to files

* Update npm test script
* Moved task contents to a task folder for Azure DevOps task to function
Copy link

@adam230594 adam230594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jack ran through the code with me, also showed me a working solution on his PC. Approved.

tasks/DependencyCheck/azure-pipelines.yml Show resolved Hide resolved
@chelnak
Copy link
Contributor

chelnak commented Mar 1, 2020

I would like to see a demo before it's merged please 👍

@chelnak
Copy link
Contributor

chelnak commented Mar 2, 2020

Had a run through with @jack-education and am happy for MVS.

@jack-education Does CI update the task version for us?

@CloudPlatformer
Copy link
Contributor Author

Had a run through with @jack-education and am happy for MVS.

@jack-education Does CI update the task version for us?

@chelnak It doesn't, shall I look to add it as part of MVS?

@chelnak
Copy link
Contributor

chelnak commented Mar 2, 2020

Maybe not for MVS but it needs to be there asap afterwards.

@CloudPlatformer CloudPlatformer merged commit 72f4f18 into master Mar 2, 2020
@CloudPlatformer CloudPlatformer deleted the dependency_check branch March 2, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants