Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vectorized 4:2:0 subsampling #1551

Merged
merged 2 commits into from
Feb 15, 2021
Merged

Fix vectorized 4:2:0 subsampling #1551

merged 2 commits into from
Feb 15, 2021

Conversation

tkp1n
Copy link
Contributor

@tkp1n tkp1n commented Feb 14, 2021

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes the bug reported by @jrdiver and @JimBobSquarePants in #1547/#1549 introduced in #1517.

@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

Merging #1551 (1bb7f48) into master (5f8f082) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1551      +/-   ##
==========================================
- Coverage   70.62%   70.62%   -0.01%     
==========================================
  Files         742      742              
  Lines       32830    32829       -1     
  Branches     3667     3668       +1     
==========================================
- Hits        23186    23185       -1     
  Misses       8930     8930              
  Partials      714      714              
Flag Coverage Δ
unittests 70.62% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/ImageSharp/Formats/Jpeg/Components/Block8x8F.cs 68.08% <100.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f8f082...1bb7f48. Read the comment docs.

@brianpopow brianpopow linked an issue Feb 14, 2021 that may be closed by this pull request
4 tasks
@JimBobSquarePants
Copy link
Member

Lovely @tkp1n I'll have a look tonight. 👍

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test output looks good visually.

@JimBobSquarePants JimBobSquarePants merged commit db51f69 into SixLabors:master Feb 15, 2021
JimBobSquarePants added a commit that referenced this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vectorized 4:2:0 subsampling leads to artifacts during Jpeg encoding.
4 participants