Skip to content

Add Foreground Service to keep WebSocket alive #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnkushMalaker merged 2 commits into from
Sep 9, 2025
Merged

Add Foreground Service to keep WebSocket alive #79

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c4eb93
Add Foreground Service to keep WebSocket alive
Sep 6, 2025
90f610c
Update package-lock for added Notifee dependency
Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions app/app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@
"android.permission.BLUETOOTH",
"android.permission.BLUETOOTH_ADMIN",
"android.permission.BLUETOOTH_CONNECT",
"android.permission.ACCESS_NETWORK_STATE"
"android.permission.ACCESS_NETWORK_STATE",
"android.permission.FOREGROUND_SERVICE",
"android.permission.FOREGROUND_SERVICE_DATA_SYNC",
"android.permission.POST_NOTIFICATIONS"
],
"usesCleartextTraffic": true
},
Expand All @@ -45,6 +48,18 @@
"bluetoothAlwaysPermission": "This app uses Bluetooth to connect to and interact with nearby BLE devices."
}
],
[
"./plugins/with-ws-fgs",
{
"android": {
"permissions": [
"FOREGROUND_SERVICE",
"FOREGROUND_SERVICE_DATA_SYNC",
"POST_NOTIFICATIONS"
]
}
}
],
Comment on lines +51 to +62
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Plugin options don’t match the plugin’s API.

with-ws-fgs expects { microphone?: boolean }. The passed { android: { permissions: [...] } } is ignored. If you’ll ever record from mic, pass microphone: true; otherwise remove options to avoid confusion.

Apply:

-      [
-        "./plugins/with-ws-fgs",
-        {
-          "android": {
-            "permissions": [
-              "FOREGROUND_SERVICE",
-              "FOREGROUND_SERVICE_DATA_SYNC",
-              "POST_NOTIFICATIONS"
-            ]
-          }
-        }
-      ],
+      ["./plugins/with-ws-fgs", { "microphone": false }],

If you plan to capture mic audio later, also add RECORD_AUDIO under android.permissions.

🏁 Script executed:

#!/bin/bash
# Locate the with-ws-fgs plugin file in the repository
file=$(fd -I with-ws-fgs -t f | head -1)
echo "Found plugin file: $file"
# Display the first 200 lines for inspection
sed -n '1,200p' "$file"

Length of output: 2125

Plugin options only support the microphone flag; remove the android field
with-ws-fgs is defined as (config, { microphone?: boolean }) and ignores other options. Replace your plugin entry with:

-      [
-        "./plugins/with-ws-fgs",
-        {
-          "android": {
-            "permissions": [
-              "FOREGROUND_SERVICE",
-              "FOREGROUND_SERVICE_DATA_SYNC",
-              "POST_NOTIFICATIONS"
-            ]
-          }
-        }
-      ],
+      ["./plugins/with-ws-fgs", { "microphone": false }],

If you plan to record audio, use { "microphone": true } and manually add android.permission.RECORD_AUDIO to your AndroidManifest (e.g. via expo-build-properties or another config plugin).

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
[
"./plugins/with-ws-fgs",
{
"android": {
"permissions": [
"FOREGROUND_SERVICE",
"FOREGROUND_SERVICE_DATA_SYNC",
"POST_NOTIFICATIONS"
]
}
}
],
["./plugins/with-ws-fgs", { "microphone": false }],
🤖 Prompt for AI Agents 
In app/app.json around lines 51 to 62, the with-ws-fgs plugin entry passes an
unsupported "android" object; the plugin only accepts a single optional
"microphone" boolean. Replace the current plugin options with either no options
or { "microphone": true } and remove the entire "android" field. If you need
audio recording also add android.permission.RECORD_AUDIO to AndroidManifest via
expo-build-properties or another config plugin.

[
"expo-build-properties",
{
Expand All @@ -60,4 +75,4 @@
}
}
}
}
}
Loading
Loading